I think I nabbed the bug that was storing the invalid comment counts on post edit. Therefore, front-end filtering of comment count should not be necessary and is disabled unless you put the following line in wp-config.php:

As you discovered before, any remaining corrupted comment count can be cleared by re-saving the post as an administrator.

I would appreciate hearing if this proves to resolve your issues.

In the flt_recent_comments function of plugins/role-scoper/hardway/hardway_rs.php:

change:

to:

Can you run a test in your single.php template file and tell me if is_attachment() evaluates true?

Okay, so as not to confuse the issue, make sure you have not defined SCOPER_FILTER_COMMENT_COUNT.

Then as a sanity check, the next thing I'd like to know is what happens if you temporarily change:

to:

…in hardway_rs.php. This will tell us if I'm barking up the wrong tree. While you're at it, you might throw a temporary

into the top of flt_recent_comments just to make sure you're not editing the wrong copy or role scoper. I'll check back in Monday.

echo defined("SCOPER_FILTER_COMMENT_COUNT")

//shows nothing

iif ( is_administrator_rs() ) die('trying');

//dies as expected

if ( false && ! is_attachment() && ! is_administrator_rs() ) {

//Behavior did not change

Since the comment count is a stored value, it will be off until the next comment is posted with the flt_recent_comments fix in place. If you must have the count updated immediately, submit & delete a fake comment or define SCOPER_FILTER_COMMENT_COUNT (and live with the extra front-end DB queries).

Still didn't get it - note that simply enabling/disabling RoleScoper also causes the zero/correct comment counts to show (without the need for someone to post an additional comment).  The correct values are being stored, i beleive - just not shown…

//ALWAYS RETURNS ZERO (if RS enabled)
    echo get_comments_number($thisVideo->ID) . ' Comments';   

See fiirst post in this thread

$videos = get_posts('numberposts=1000&post_type=attachment&post_parent='.$post->ID);
foreach($videos as $thisVideo)
{
    echo "…thumbnail, link, etc…";

   //ALWAYS RETURNS ZERO
    echo get_comments_number($thisVideo->ID) . ' Comments';   
}

Ah, I see the confusion.  The code I mentioned is not for individual videos, but for the video listing here:

http://www.justin-klein.com/wordpress/videos

It's a "Page" to which I add the attachments (videos). It, like the individual video pages (and photos in some private photo galleries), all echo "0″ for comment counts on attachments.  The full code (minus the header) for that listing is:

$videos = get_posts('numberposts=1000&post_type=attachment&post_parent='.$post->ID);
foreach($videos as $thisVideo)
{
    //Skip image attachments (these will correspond to the video thumbnails)
    if( wp_attachment_is_image( $thisVideo->ID ) ) continue;
   
    //Show the video's thumbnail (stored in the "excerpt" field)
    echo "\n<div class=\"galleryImg\">\n".
    "\t<a href=\"". get_permalink($thisVideo->ID) ."\">" . $thisVideo->post_excerpt . "</a>\n</div>\n";
   
    //Title, time, and country
    echo '<div class="galleryTxt">';
    echo '<h1><a href="' . get_permalink($thisVideo->ID) . '">' . $thisVideo->post_title . '</a></h1>';
    echo '<small>' . mysql2date('F j, Y', $thisVideo->post_date_gmt) . ' in ' . get_country($thisVideo->ID)  . '<br />';
    echo get_comments_number($thisVideo->ID) . ' Comments';   
    if( function_exists('get_view_count') ) echo ', ' . $thisVideo->view_count . ' views.<br />';
    echo '</small>';
    echo '<br />' . strip_tags($thisVideo->post_content) . '<br />';
    echo '</div>';
   
    echo "<br clear=\"all\" />\n";
    echo "<hr />\n";
}